Remove unmaintained ansi_term, clap crates and update env_logger #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansi_term is an unmaintained crate that we can remove. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
|
Removing it does not break anything... I think this was not being used? @ionut-arm @gowthamsk-arm |
Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
* clap crate is not currently being used. Remove it. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
tgonzalezorlandoarm
changed the title
|
PS: you can use cargo-udeps to check for unused dependencies! |
|
Hi @hug-dev, Thanks a lot for the comment! Yes, we are (and were) using that. The thing that caught my attention was that we had this marked as an exception for cargo audit (please see https://github.com/parallaxsecond/parsec-tool/pull/107/files#diff-42d80c82c252835c55a95ccaecb4b8583244e79721e5dd62864e11e2dc89eb65R2) instead of just removing the crate, that's why I asked them to verify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ansi_term is an unmaintained crate that we can remove.